Mentioning the user when a nomination 'fails'#2040
Merged
Conversation
ChrisLovering
requested changes
Jan 7, 2022
ChrisLovering
previously requested changes
Jan 8, 2022
presumed that when target was an integer, it would be the user ID and not the nomination ID. retrieves user from nomination and fetches the user
ChrisLovering
added
a: frontend
vivekashok1221
previously requested changes
Jan 10, 2022
Contributor
|
Hi @Shom770, what's the status on this PR? |
Contributor
|
@Shom770 Wold you like this PR to go up for grabs if you're not able to work on it anymore? |
Contributor
Author
yeah sure, i've been really busy with school 😅 |
Contributor
|
Very well. Thanks for the quick response! |
Xithrius
added
up for grabs
MarkKoz
requested review from
ChrisLovering and
vivekashok1221
and removed request for
ChrisLovering
HassanAbouelela
approved these changes
Jun 9, 2022
HassanAbouelela
dismissed stale reviews from ChrisLovering and vivekashok1221
Stale
ChrisLovering
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when someone has already nominated the user, it simply says that the nomination already exists, but doesn't mention the user.
The same goes for when someone edits the nomination reason for a user, it doesn't mention the user itself just the fact that the nomination reason changed.
It's helpful to know who the user is because most of the time you won't know the user by their ID which most people use for nominating.
Permission to open a PR directly:
https://discord.com/channels/267624335836053506/822920136150745168/928694255734632478