Skip to content

Add embed message mentioning help channel claimant#2062

Merged
MarkKoz merged 2 commits into
python-discord:mainfrom
minalike:help-claimant-embed
Jan 27, 2022
Merged

Add embed message mentioning help channel claimant#2062
MarkKoz merged 2 commits into
python-discord:mainfrom
minalike:help-claimant-embed

Conversation

@minalike
Copy link
Copy Markdown
Contributor

Closes #2060

This PR adds a message by the bot stating who the help channel claimant is.
image

This is my first code contribution to Python Discord and my first time working with discord.py so during your review it is safe to assume that I know nothing.

I'm not sure if the embed should be sent before or after the channel is moved. But I would like it to be sent at least before the claimant's message is pinned.

@minalike minalike added a: help channels Related to the help channel system s: needs review Author is waiting for someone to review and approve labels Jan 27, 2022
@minalike minalike requested a review from MarkKoz as a code owner January 27, 2022 15:48
Copy link
Copy Markdown
Contributor

@ToxicKidz ToxicKidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and looks good to me, thanks for the change!

Copy link
Copy Markdown
Contributor

@D0rs4n D0rs4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out locally, seems to be working fine.
Thank you for the PR!

@D0rs4n D0rs4n enabled auto-merge January 27, 2022 16:33
@MarkKoz MarkKoz disabled auto-merge January 27, 2022 16:53
@MarkKoz MarkKoz enabled auto-merge (rebase) January 27, 2022 16:54
@MarkKoz MarkKoz merged commit 30fee62 into python-discord:main Jan 27, 2022
@minalike minalike deleted the help-claimant-embed branch January 27, 2022 16:57
@Xithrius Xithrius removed the s: needs review Author is waiting for someone to review and approve label Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: help channels Related to the help channel system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

State claimer on help channels

5 participants