Notify helpers without ping when dormant channels are running low#2071
Merged
ToxicKidz merged 20 commits intoFeb 24, 2022
Merged
Conversation
minalike
added
t: feature
MarkKoz
requested changes
Feb 3, 2022
Xithrius
added
p: 2 - normal
MarkKoz
requested changes
Feb 22, 2022
MarkKoz
reviewed
Feb 22, 2022
minalike
commented
Feb 22, 2022
MarkKoz
previously approved these changes
Feb 23, 2022
MarkKoz
dismissed
their stale review
Didn't see that finally wasn't changed to else
ToxicKidz
reviewed
Feb 23, 2022
total_seconds() is the correct method to obtain a time delta in seconds
MarkKoz
approved these changes
Feb 23, 2022
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2051
This PR adds a non-pinging notification to
#helpersto alert staff when we are running low on dormant channels. The threshold for when this notification is triggered is added as a configurable.