Traceback tag: Emphasize reason for sharing traceback#2072
Merged
Conversation
The previous version talks about how to read a traceback, but this tag is most often used to help the asker provide the traceback. This version is more brief and emphasizes why they are being asked to provide the traceback, and uses an example that I think is slightly more illustrative.
swfarnsworth
added
a: help channels
Contributor
Author
|
I meant to include a link to the pastebin for long tracebacks. Please don't merge this until I add that. |
Refers users to the pastebin, in case the traceback is long.
ToxicKidz
suggested changes
Feb 11, 2022
Contributor
ToxicKidz
left a comment
ToxicKidz
left a comment
There was a problem hiding this comment.
Looks good, just one comment regarding the traceback.
Line number and location were the same for both steps of the traceback; I created an actual `my_file.py` that causes the traceback to ensure everything is right.
Contributor
Author
|
I think we can do a squash merge for this one? |
Xithrius
added
p: 3 - low
Xithrius
approved these changes
Feb 13, 2022
Contributor
Xithrius
left a comment
Xithrius
left a comment
There was a problem hiding this comment.
Sorry I took so long to review. After reading over it multiple times, I see no error in your ways, and I have no suggestions to improve. Off it goes, to production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version talks about how to read a traceback, but this tag is most often used to help the asker provide the traceback. This version is more brief and emphasizes why they are being asked to provide the traceback, and uses an example that I think is slightly more illustrative.