Don't validate reminder author#2080
Merged
Merged
Conversation
Validation relies on the cache which might not be properly filled. This can cause reminders to be sent for users who are no longer in the server, which seems negligible.
jb3
approved these changes
Feb 11, 2022
Member
Author
|
Don't be alarmed by the line count, the merge commit brought back the entire file. The actual change is the first commit which is an 8-line change |
ChrisLovering
approved these changes
Feb 11, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder validation relied on the member cache which might not be properly filled, which caused some reminders to not be sent.
This PR removes this part of the validation. This can cause reminders to be sent for users who are no longer in the server, but this seems negligible.
While #1919 might be more thorough, the changes here are very simple and will allow us to have the reminders cog again.