Add a cog to bump threads#2084
Merged
Merged
Conversation
ChrisLovering
force-pushed
the
thread-bumper-cog
branch
2 times, most recently
from
02e07e3 to
4dda4ca
Compare
ChrisLovering
added
a: utility
vivekashok1221
requested changes
Feb 13, 2022
Contributor
vivekashok1221
left a comment
vivekashok1221
left a comment
There was a problem hiding this comment.
Neat and concise!
ChrisLovering
force-pushed
the
thread-bumper-cog
branch
from
4dda4ca to
805a994
Compare
Xithrius
requested review from
HassanAbouelela
and removed request for
ks129
ChrisLovering
force-pushed
the
thread-bumper-cog
branch
from
ca1ccc0 to
0ae5ee9
Compare
ToxicKidz
suggested changes
Feb 16, 2022
ChrisLovering
force-pushed
the
thread-bumper-cog
branch
2 times, most recently
from
df6c8a4 to
a958d6d
Compare
ToxicKidz
suggested changes
Feb 17, 2022
ChrisLovering
force-pushed
the
thread-bumper-cog
branch
from
ab268b8 to
8181821
Compare
ToxicKidz
approved these changes
Feb 17, 2022
Contributor
ToxicKidz
left a comment
ToxicKidz
left a comment
There was a problem hiding this comment.
LGTM, works well, 
, just one comment.
ChrisLovering
force-pushed
the
thread-bumper-cog
branch
from
c68d629 to
3647317
Compare
vivekashok1221
requested changes
Feb 18, 2022
Contributor
vivekashok1221
left a comment
vivekashok1221
left a comment
There was a problem hiding this comment.
Two minor suggestions, feel free to ignore if you feel they're not needed.
| if not ctx.invoked_subcommand: | ||
| await ctx.send_help(ctx.command) | ||
|
|
||
| @thread_bump_group.command(name="add") |
Contributor
There was a problem hiding this comment.
Suggested change
| @thread_bump_group.command(name="add") | |
| @thread_bump_group.command(name="add", aliases=("a",)) |
How about adding a as an alias to add? Feel free to ignore this comment because add is short as it is, but, personally, I would expect a to be an alias for add since r is an alias for remove.
| else: | ||
| raise commands.BadArgument("You must provide a thread, or run this command within a thread.") | ||
|
|
||
| await self.threads_to_bump.set(thread.id, "sentinel") |
Contributor
There was a problem hiding this comment.
When trying to add a thread which is already in the bump list, it might be useful to send a message like "Thread is already in the bump list. ".
vivekashok1221
requested changes
Feb 18, 2022
Contributor
vivekashok1221
left a comment
vivekashok1221
left a comment
There was a problem hiding this comment.
Sorry, but I one more thing I wanted to point out 😅 .
Comment on lines
+129
to
+136
| bumped_threads = [k for k, _ in await self.threads_to_bump.items()] | ||
| if after.id in bumped_threads: | ||
| await self.unarchive_threads_not_manually_archived([after]) |
Contributor
There was a problem hiding this comment.
PS: I believe you can do something like this here instead.
Suggested change
| bumped_threads = [k for k, _ in await self.threads_to_bump.items()] | |
| if after.id in bumped_threads: | |
| await self.unarchive_threads_not_manually_archived([after]) | |
| if await bumped_threads.contains(after.id): | |
| await self.unarchive_threads_not_manually_archived([after]) |
Contributor
There was a problem hiding this comment.
You could also use RedisCache.contains() in line 88 if you decide to incorporate this suggestion.
Quite often we want threads such as event discussions, or moderation discussions to live beyond their maximum of 1 week of auto-archival. This cog allows staff to add a thread to a list that will get 'bumped' back open by the bot when they are auto-archived
ChrisLovering
force-pushed
the
thread-bumper-cog
branch
from
3647317 to
3346d71
Compare
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite often we want threads such as event discussions, or moderation discussions to live beyond their maximum of 1 week of auto-archival. This cog allows staff to add a thread to a list that will get 'bumped' back open by the bot when they are auto-archived