Allow duckifying of messages in threads#2087
Merged
Merged
Conversation
TizzySaurus
added
t: bug
ToxicKidz
reviewed
Feb 17, 2022
ChrisLovering
requested changes
Feb 18, 2022
ToxicKidz
added
s: waiting for author
ToxicKidz
added
s: needs review
ChrisLovering
approved these changes
Mar 3, 2022
Bluenix2
approved these changes
Mar 14, 2022
Contributor
Bluenix2
left a comment
Bluenix2
left a comment
There was a problem hiding this comment.
Thank you for this fix Tizzy. Managed to fix a bug and simultaneously reduce code complexity - perfect!
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1930.
Messages in threads can now be duckified!
NB: Currently untested.