Make modpings rescheduling robust to unfilled cache#2145
Merged
Conversation
Additionally, this adds a check which will remove entries in the redis cache of former moderators.
mbaruh
added
t: bug
ChrisLovering
approved these changes
Apr 23, 2022
Member
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
Forgot to press submit on this one yesterday 😅
LGTM, just one comment but doesn't really matter in the big picture, since there's a few to change anyway.
| from bot.converters import Expiry | ||
| from bot.log import get_logger | ||
| from bot.utils import time | ||
| from bot.utils.members import get_or_fetch_member |
Member
There was a problem hiding this comment.
Suggested change
| from bot.utils.members import get_or_fetch_member | |
| from botcore.utils.members import get_or_fetch_member |
One less to get in the migration :D
wookie184
approved these changes
May 1, 2022
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
LGTM, will merge this now and can do the botcore change some other time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moderators might not get their pingable role back if the discord.py cache is missing members during rescheduling. This PR makes the rescheduling resolve every entry in the redis cache.
Additionally, this adds a check which will remove entries in the redis cache of former moderators.