Manually chunk guild if not chunked 20s after startup#2152
Conversation
|
This will actually only sleep for 20s before attempting chunking. (there are 3 checks with 10s wait between then but the first one is at 0s). Would it also be worth logging some sort of exception if the guild doesn't end up chunked? I don't think there is a reason it shouldn't eventually end up chunked, only that it might take a long time to do so. If it not chunking itself is a common occurence we'd probably want to know about it as it would cause problems elsewhere in the bot. Also do we know what the behaviour if it was in the process of chunking and then |
Ah good point, I'll update PR title, not a big issue though.
Guild.chunk() is blocking until the guild is successfully chunked. I cannot spot any errors that this would raise within the chunk nor ws impl, so I wouldn't not what exception to catch if we wanted to rethrow with a custom exception.
If a chunk is in progress, the same future will be waited for, rather than start a new chunk request. https://github.com/Rapptz/discord.py/blob/master/discord/state.py#L1101-L1112 |
wookie184
left a comment
There was a problem hiding this comment.
Thanks for explaining that! This looks good to me
No description provided.