Skip to content

Update wording for or-gotcha tag #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
minalike merged 1 commit into from
Apr 29, 2022
Merged

Update wording for or-gotcha tag #2160

minalike merged 1 commit into from
Apr 29, 2022

Conversation

@mustafaquraish
Copy link
Member

@mustafaquraish mustafaquraish commented Apr 29, 2022

As described in #2128

@minalike minalike linked an issue Apr 29, 2022 that may be closed by this pull request
Make wording for !or-gotcha more explicit #2128
Closed
@minalike minalike removed a link to an issue Apr 29, 2022
Make wording for !or-gotcha more explicit #2128
Closed
@minalike minalike linked an issue Apr 29, 2022 that may be closed by this pull request
Make wording for !or-gotcha more explicit #2128
Closed
minalike
minalike approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@minalike minalike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The above activity was me experimenting with whether "as described in" would link the PR to the issue. I don't believe it does; see here for the supported keywords)

I like the change, thanks for the PR!

@minalike minalike merged commit b9b5fa7 into main Apr 29, 2022
@minalike minalike deleted the 2128 branch April 29, 2022 23:41
@mustafaquraish
Copy link
Member Author

mustafaquraish commented Apr 30, 2022

see here for the supported keywords

TIL! For some reason I had just assumed GitHub magically does the thing whenever you mention an issue in a PR. Thanks for the helpful link 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minalike minalike minalike approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make wording for !or-gotcha more explicit

3 participants

@mustafaquraish @minalike