Fix help embed views#2197
Merged
Merged
Conversation
Due to various breaking changes in the discord.py library the views of the help embed stopped working properly. - Use `add_item` in `CommandView`. This was done in GroupView but was apparently missed in `CommandView`, and the former (hacky) method no longer works. - Instead of editing the help message normally (which required to then defer the response), the message edit is made to be the response itself. It seems like the callback would automatically defer the response if none was made, but that no longer happens.
mbaruh
added
t: bug
MarkKoz
approved these changes
Jun 19, 2022
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
I'm not familiar with the interactions API, so I can't be effective in reviewing the code. I can't even find where it's documented. However, these changes do work in practice.
ChrisLovering
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to various breaking changes in the discord.py library the views of the help embed stopped working properly.
add_iteminCommandView. This was done in GroupView but was apparently missed inCommandView, and the former (hacky) method no longer works.