Add Aliases for Tags Support#2213
Merged
Merged
Conversation
Adds an "aliases" metadata option to provide alternative names for a tag. Adds the alias names as additional identifiers to search for.
For our favorite bot admin and to showcase how aliases should look in the tag file itself.
janine9vn
added
p: 2 - normal
Xithrius
requested review from
Bluenix2,
ChrisLovering and
HassanAbouelela
and removed request for
Den4200 and
jb3
Adds an "aliases" metadata option to provide alternative names for a tag. Adds the alias names as additional identifiers to search for.
For our favorite bot admin and to showcase how aliases should look in the tag file itself.
…nto tag-aliases
ChrisLovering
approved these changes
Jul 11, 2022
Numerlor
approved these changes
Jul 11, 2022
shenanigansd
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding aliases and alternative names for tags and showcases it with two existing tags.
It uses the metadata functionality and will look for the "aliases" key. It then adds the alias names to the Tags dictionary that gets searched through when trying to match a tag directly.
This doesn't check for duplicate aliases as there wasn't a good way to do that validation ahead of time. It also didn't feel like a good solution to iterate through all TagIdentifiers to find possible duplicate matches. So I'm relying on folks who are PRing things to not add conflicting aliases.
Example of the alias in action
