Skip to content

Update !modpings off confirmation to use a discord timestamp.#2220

Merged
wookie184 merged 2 commits into
mainfrom
fix-bot-2168
Jul 23, 2022
Merged

Update !modpings off confirmation to use a discord timestamp.#2220
wookie184 merged 2 commits into
mainfrom
fix-bot-2168

Conversation

@TizzySaurus
Copy link
Copy Markdown
Contributor

Closes #2168.

The embed confirmation in !modpings off has been removed in favour of a standard message using the new discord timestamp feature to show both the date and time.

NB: Currently untested as on holiday, but everything should be good. I've added the "do not merge" tag until this is verified.

@TizzySaurus TizzySaurus added a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 3 - low Low Priority t: enhancement Changes or improvements to existing features s: needs review Author is waiting for someone to review and approve review: do not merge The PR can be reviewed but cannot be merged now labels Jul 14, 2022
@TizzySaurus TizzySaurus removed the review: do not merge The PR can be reviewed but cannot be merged now label Jul 15, 2022
@TizzySaurus TizzySaurus marked this pull request as draft July 15, 2022 21:49
@ChrisLovering ChrisLovering removed the s: needs review Author is waiting for someone to review and approve label Jul 17, 2022
@TizzySaurus
Copy link
Copy Markdown
Contributor Author

Have confirmed that the new !modpings off command message works as intended:

image

This PR is now ready for review 😄

@TizzySaurus TizzySaurus marked this pull request as ready for review July 23, 2022 07:43
@TizzySaurus TizzySaurus added the s: needs review Author is waiting for someone to review and approve label Jul 23, 2022
Copy link
Copy Markdown
Contributor

@minalike minalike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

Copy link
Copy Markdown
Contributor

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested,
LGTM 🌟 .

@wookie184 wookie184 merged commit 31110a7 into main Jul 23, 2022
@wookie184 wookie184 deleted the fix-bot-2168 branch July 23, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 3 - low Low Priority s: needs review Author is waiting for someone to review and approve t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show full date & timestamp in !modpings off message

5 participants