feat(tags): add print-return tag#2224
Merged
Merged
Conversation
Since we already create the tag embed from the `embed` object in the metadata, we already have the support to add images in embeds, albeit a bit more verbose than if we had added a `media` property in the metadata containing only the URL.
Numerlor
reviewed
Jul 17, 2022
Contributor
Numerlor
left a comment
Numerlor
left a comment
There was a problem hiding this comment.
Should we be using discord's cdn for the gif instead of hosting it somewhere ourselves?
Contributor
Author
Do we have our own CDN to host images? |
Member
|
You can upload the GIF to this repo and then reference the github raw URL for it in the embed. The benefit is that this embed won't stop working if the original message is delete from within Discord. |
As discussed in https://discord.com/channels/267624335836053506/635950537262759947/998235482494353508, using the raw GitHub URL for the GIF would be more reliable than the Discord CDN URL.
As mentioned in the previous commit, using the raw GitHub URL would be more reliable than a Discord CDN URL.
minalike
added
a: tags
lemonsaurus
approved these changes
Jul 24, 2022
Contributor
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
Please can we just change all our tags into animated gifs? Holy shit this is so cool. I wish I could approve this more than once. ✅ ✅✅✅✅✅✅✅✅✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we already create the tag embed from the
embedobject in the metadata, we already have thesupport to add images in embeds, albeit a bit more verbose than if we had added a
mediapropertyin the metadata containing only the URL.
Closes #2222
Closes python-discord/meta#187