Add nomodule tag#2230
Conversation
CaedenPH
left a comment
CaedenPH
left a comment
There was a problem hiding this comment.
Explains well in detail about the module not found and how to fix but doesn't necessarily mention about what a module actually is. Seems more like a temporary fix rather than teaching the reader what exactly a module is and how to avoid module not found.
| ``` | ||
| python -m pip install <your_package> | ||
| ``` | ||
| (You may have to specify the full path to the python executable). |
There was a problem hiding this comment.
This is slightly ambiguous and may confuse the reader
There was a problem hiding this comment.
Agreed. It may be best to leave it out unless it can be explained briefly and clearly how "xxx -m pip install ..." means the package is available if using "xxx file.py"/"xxx -m mymodule" to run the code.
|
@meatballs Hello. It seems you have a request for change on this PR. Please resolve it, so we're able to get this merged. Thanks! |
Xithrius
added
t: feature
|
What's the requested change? I can see an opinion but it's not one I agree with. |
Tags must be limited in scope. Otherwise they become long and loose their effectiveness. I don't think it's possible to explain what a module is in this tag in addition to what the error is without making the content long and overwhelming. Did you have something in mind that would suggest otherwise? |
| @@ -0,0 +1,15 @@ | |||
| **ModuleNotFoundError** | |||
|
|
|||
| If you've installed a package but you're getting a ModuleNotFoundError, it's likely that the environment where your code is running is different from the one where you did the installation. | |||
There was a problem hiding this comment.
What do you think about briefly clarifying here that the error happens upon importing the purportedly installed package?
5 participants
Fixes python-discord/meta#189