Add ability to delete multiple reminders at once & display mentions in !remind list.#2232
Merged
Conversation
TizzySaurus
added
a: backend
wookie184
requested changes
Sep 17, 2022
- Convert `ids` to a set to remove duplicates - Limit the amount of reminders you can delete at once to 5 in order to prevent API spam
vivekashok1221
approved these changes
Sep 20, 2022
Contributor
vivekashok1221
left a comment
vivekashok1221
left a comment
There was a problem hiding this comment.
Reviewed and tested.
LGTM 🌟 .
wookie184
requested changes
Sep 20, 2022
Added so that the user still gets information on what the mention is, when the mention doesn't render (due to client cache etc.)
wookie184
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #2231.
Delete Multiple Reminders
This has been tested with the help of @ichard26 (thanks!).
The behaviour behind the deletion is still the exact same (you can't delete others' reminders unless you're an admin), just has been reformatted to account for the fact that a lock needs to be applied to each individual id.
There's also some changes to prevent a message being sent for each deletion fail -- we instead send one message after processing all ids.
All reminders successfully deleted:
Some reminders successfully deleted:
No reminders were successfully deleted:
Display Mentions
!remind listwill now display the.mentionattribute, instead of the.nameattribute to be clearer.Before:
After:
