Add support to fetch rules via keywords#2261
Merged
MarkKoz merged 42 commits intoSep 21, 2022
Merged
Conversation
added 2 commits
August 19, 2022 15:10
This doesn't change the way the rules command originally worked and keeps the priority to rule numbers. But in case a number (or numbers) is not supplied, it will try to find a rule that maps to a the supplied keyword.
Contributor
Author
shtlrs
commented
Aug 31, 2022
MarkKoz
requested changes
Sep 8, 2022
added 5 commits
September 8, 2022 23:11
MarkKoz
requested changes
Sep 11, 2022
added 8 commits
September 16, 2022 16:59
This doesn't change the way the rules command originally worked and keeps the priority to rule numbers. But in case a number (or numbers) is not supplied, it will try to find a rule that maps to a the supplied keyword.
…ywords' into 2108-invoke-rule-command-with-keywords
MarkKoz
requested changes
Sep 18, 2022
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
Functionally, everything is fine. However, I have some suggestions to improve the code.
added 3 commits
September 18, 2022 21:56
…ule_number using the matched keywords
MarkKoz
requested changes
Sep 18, 2022
added 5 commits
September 19, 2022 13:03
…sent in the input
TizzySaurus
reviewed
Sep 19, 2022
MarkKoz
requested changes
Sep 19, 2022
MarkKoz
requested changes
Sep 20, 2022
MarkKoz
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.