Skip to content

Removed italics from the help command #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wookie184 merged 4 commits into from
Sep 17, 2022
Merged

Removed italics from the help command #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b5f2f6
removed asterisk from embed description
Ibrahim2750mi Sep 3, 2022
0525d79
removed italics from line 334, 375 and 415
Ibrahim2750mi Sep 9, 2022
ee43b2a
pagination.py, L239 added italics
Ibrahim2750mi Sep 10, 2022
38a3590
Merge branch 'main' into remove-italics
wookie184 Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bot/exts/info/help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ async def command_formatting(self, command: Command) -> tuple[Embed, Optional[Co
# Remove line breaks from docstrings, if not used to separate paragraphs.
# Allow overriding this behaviour via putting \u2003 at the start of a line.
formatted_doc = re.sub("(?<!\n)\n(?![\n\u2003])", " ", command.help)
command_details += f"*{formatted_doc or 'No details provided.'}*\n"
command_details += f"{formatted_doc or 'No details provided.'}\n"
embed.description = command_details

# If the help is invoked in the context of an error, don't show subcommand navigation.
Expand All @@ -331,7 +331,7 @@ def get_commands_brief_details(commands_: List[Command], return_as_list: bool =
for command in commands_:
signature = f" {command.signature}" if command.signature else ""
details.append(
f"\n**`{PREFIX}{command.qualified_name}{signature}`**\n*{command.short_doc or 'No details provided'}*"
f"\n**`{PREFIX}{command.qualified_name}{signature}`**\n{command.short_doc or 'No details provided'}"
)
if return_as_list:
return details
Expand Down Expand Up @@ -372,7 +372,7 @@ async def send_cog_help(self, cog: Cog) -> None:

embed = Embed()
embed.set_author(name="Command Help", icon_url=constants.Icons.questionmark)
embed.description = f"**{cog.qualified_name}**\n*{cog.description}*"
embed.description = f"**{cog.qualified_name}**\n{cog.description}"

command_details = self.get_commands_brief_details(commands_)
if command_details:
Expand Down Expand Up @@ -412,7 +412,7 @@ async def send_category_help(self, category: Category) -> None:
filtered_commands = await self.filter_commands(all_commands, sort=True)

command_detail_lines = self.get_commands_brief_details(filtered_commands, return_as_list=True)
description = f"**{category.name}**\n*{category.description}*"
description = f"**{category.name}**\n{category.description}"

if command_detail_lines:
description += "\n\n**Commands:**"
Expand Down
2 changes: 1 addition & 1 deletion bot/pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ async def paginate(
raise EmptyPaginatorEmbedError("No lines to paginate")

log.debug("No lines to add to paginator, adding '(nothing to display)' message")
lines.append("(nothing to display)")
lines.append("*(nothing to display)*")

for line in lines:
try:
Expand Down