1379 tranform urls upon rich embed filter application #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 28, 2022 08:29
We add the transformed urls to the set to account for the way discord renders relative urls in cases like Twitter's
Member
Author
shtlrs
requested review from
ChrisLovering
and removed request for
jb3 and
mbaruh
ChrisLovering
approved these changes
Oct 1, 2022
Member
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
Looks good and works well.
mbaruh
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1379
The current implementation allows to collect the URLs from the sent messages and then apply a transformation on them.
The transformation here is basically a removal of the subdomain (if it exists) because of the way Discord renders some URLs (Twitter's in particular)