Skip to content

Pass args to the Python version switch button #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisLovering merged 2 commits into from
Nov 2, 2022
Merged

Pass args to the Python version switch button #2315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b893637
Pass args to the Python version switch button
ks129 Oct 28, 2022
eb6f7d0
Merge branch 'main' into bug/2299/timeit
ChrisLovering Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions bot/exts/utils/snekbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def __init__(
version_to_switch_to: Literal["3.10", "3.11"],
snekbox_cog: "Snekbox",
ctx: Context,
code: str
code: str,
args: Optional[list[str]] = None
) -> None:
self.version_to_switch_to = version_to_switch_to
super().__init__(label=f"Run in {self.version_to_switch_to}", style=enums.ButtonStyle.primary)
Expand All @@ -134,6 +135,7 @@ def __init__(
self.ctx = ctx
self.job_name = job_name
self.code = code
self.args = args

async def callback(self, interaction: Interaction) -> None:
"""
Expand All @@ -150,7 +152,9 @@ async def callback(self, interaction: Interaction) -> None:
# The log arg on send_job will stop the actual job from running.
await interaction.message.delete()

await self.snekbox_cog.run_job(self.job_name, self.ctx, self.version_to_switch_to, self.code)
await self.snekbox_cog.run_job(
self.job_name, self.ctx, self.version_to_switch_to, self.code, args=self.args
)


class Snekbox(Cog):
Expand All @@ -165,7 +169,8 @@ def build_python_version_switcher_view(
job_name: str,
current_python_version: Literal["3.10", "3.11"],
ctx: Context,
code: str
code: str,
args: Optional[list[str]] = None
) -> None:
"""Return a view that allows the user to change what version of Python their code is run on."""
if current_python_version == "3.10":
Expand All @@ -177,7 +182,7 @@ def build_python_version_switcher_view(
allowed_users=(ctx.author.id,),
allowed_roles=MODERATION_ROLES,
)
view.add_item(PythonVersionSwitcherButton(job_name, alt_python_version, self, ctx, code))
view.add_item(PythonVersionSwitcherButton(job_name, alt_python_version, self, ctx, code, args))
view.add_item(interactions.DeleteMessageButton())

return view
Expand Down Expand Up @@ -357,7 +362,7 @@ async def send_job(
response = await ctx.send("Attempt to circumvent filter detected. Moderator team has been alerted.")
else:
allowed_mentions = AllowedMentions(everyone=False, roles=False, users=[ctx.author])
view = self.build_python_version_switcher_view(job_name, python_version, ctx, code)
view = self.build_python_version_switcher_view(job_name, python_version, ctx, code, args)
response = await ctx.send(msg, allowed_mentions=allowed_mentions, view=view)
view.message = response

Expand Down