Update modlog for threads#2357
Merged
Merged
Conversation
jchristgit
approved these changes
Dec 9, 2022
Contributor
jchristgit
left a comment
There was a problem hiding this comment.
Awesome pull request!!!
Contributor
|
Do we want to move thread name edits too? I don't really mind |
MarkKoz
approved these changes
Dec 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With some discussion with mods, it was agreed that logging thread creation wasn't needed, for the same reasons we do not log message creations.
Thread edits & deletes are still wanted, but mod-log doesn't seem like the right place for it. Since it serves a similar purpose to our message logs, we decided to place it there instead.