Trim query in command not found error to avoid embed limits#2380
Merged
Conversation
ChrisLovering
approved these changes
Jan 14, 2023
Member
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
minor suggestion, looks good otherwise
wookie184
added
t: bug
Ibrahim2750mi
approved these changes
Feb 26, 2023
henri-climber
approved these changes
Feb 28, 2023
mbaruh
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor to #2286
Closes #2257
I ended up moving the trimming logic so only the query is trimmed, so you get something like
Query "long..." not foundrather thanQuery "long....I also didn't use
textwrap.shortenas that only breaks on words, so if the input had no spaces you would just get something likeQuery "..." not found.