Make sure interaction_owner is an instance attribute#2384
Closed
mbaruh wants to merge 1 commit into
Closed
Conversation
If it's a class attribute then the interaction owner of all current views will be the last person to view the buttons.
Robin5605
approved these changes
Jan 22, 2023
Contributor
Robin5605
left a comment
Robin5605
left a comment
There was a problem hiding this comment.
Should the interaction_owner docstring still be kept around? Theoretically speaking one could still access it via role_button_view_instance.interaction_owner given that role_button_view_instance is an instance of RoleButtonView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If it's a class attribute then the interaction owner of all current views will be the last person to view the buttons.