Skip to content

Fix typo in help channel opening embed#2389

Merged
mbaruh merged 2 commits into
mainfrom
shenanigansd-patch-1
Jan 26, 2023
Merged

Fix typo in help channel opening embed#2389
mbaruh merged 2 commits into
mainfrom
shenanigansd-patch-1

Conversation

@shenanigansd
Copy link
Copy Markdown
Contributor

@shenanigansd shenanigansd commented Jan 26, 2023

Copy link
Copy Markdown
Contributor

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has caught me off before. However, there is a grammatically correct interpretation as-is, though it isn't the first one I come to naturally. It can be read as "If you got one" -> "if you got an error message" -> "if you got an error message when you ran the code"

@MarkKoz
Copy link
Copy Markdown
Contributor

MarkKoz commented Jan 26, 2023

Ah well we have #2386 so there probably is no point in merging this. It'll just create conflicts and the impact of the issue this solves is minimal.

Disregard, that's for a different embed message than the one this PR touches.

Copy link
Copy Markdown
Contributor

@whispersofthedawn whispersofthedawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

I agree that there is a valid interpretation, but the wording this PR proposes is more clear.

@mbaruh mbaruh enabled auto-merge January 26, 2023 02:11
@mbaruh mbaruh merged commit 9ccd492 into main Jan 26, 2023
@mbaruh mbaruh deleted the shenanigansd-patch-1 branch January 26, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants