Add warning message when using input with eval command#2422
Conversation
inputinput with eval command
+ Double quotes for consistency + Using results["stdout"] instead of output so the warning is still displayed if the error doesn't fit in the message. + Using endswith so we don't need to hardcode the constant. Co-authored-by: wookie184 <wookie1840@gmail.com>
f99a12f to
f3c1038
Compare
|
Also wookie thanks for reviewing |
mbaruh
left a comment
There was a problem hiding this comment.
A false positive here would be
!e raise ValueError("EOFError: EOF when reading a line")Not sure this is worth handling though. If you tried to find input in the eval input you would also have a false positive in the form of someone shadowing the built-in, as beginners often do.
I also realised this and commented it in the first review there wookie recommended to leave this as no user would do this.
Just doing |
|
Sort of along the same lines as #2255 , how feasible would it be to add a modal with a |
I don't get whats the use of adding any input, |
Closes #2420
Closes (MAYBE) #2255
No need to check if input is in their code as the docs say
EOFErroris only raised whenScreenshots:

