Centralise error handling for commands invoked from error handler#2436
Merged
Conversation
wookie184
added
t: bug
Ibrahim2750mi
approved these changes
Mar 11, 2023
Contributor
Ibrahim2750mi
left a comment
Ibrahim2750mi
left a comment
There was a problem hiding this comment.
LGTM! Also thanks for fixing test_dont_call_suggestion_if_user_mod using ctx.invoke.
TizzySaurus
reviewed
May 4, 2023
ChrisLovering
approved these changes
Sep 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1620
The error that prompted the original issue can be reproduced my spamming
!shhhvery quickly. This PR is a more general improvement that fixes this issue, ensuring all errors raised by commands run from the error handler are redirected to the error handler.