Skip to content

Add Tag Issue Template#2540

Closed
HassanAbouelela wants to merge 2 commits into
mainfrom
tag-suggestion-template
Closed

Add Tag Issue Template#2540
HassanAbouelela wants to merge 2 commits into
mainfrom
tag-suggestion-template

Conversation

@HassanAbouelela
Copy link
Copy Markdown
Contributor

People (contribs, staff, and core-devs alike) have often been confused by where to create issues for adding new tags. Creating issues on this repository makes the most sense - issue follows implementation - but it's rarely the correct option. Tag suggestions issues are never about implementation details, but specific tag details such as: do we want this? what form do we want it in? etc.

These questions can not be discussed adequately on this repository as it's difficult to gain traction and get people seeing it. The meta repository is a much better location for it, and hence the tag suggestion template exists. This is an attempt at guiding people towards it.

Add an issue template for creating tags, which redirects people
towards the correct repository.
@HassanAbouelela HassanAbouelela added a: docs Adds or updates documentation p: 2 - normal Normal Priority t: enhancement Changes or improvements to existing features labels Apr 15, 2023
Copy link
Copy Markdown
Contributor

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, just one tiny comment.

@@ -0,0 +1,17 @@
name: Tag Suggestion
description: Suggest a new tag.
title: I DID NOT READ THE INSTRUCTIONS
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest making it clearer, as this currently sounds like an "inside joke". (The fact that people never read the instructions, so we made this)

For example

Suggested change
title: I DID NOT READ THE INSTRUCTIONS
title: TAG ISSUES GO TO THE META REPO, PLEASE READ THE FOLLOWING INSTRUCTIONS

@wookie184
Copy link
Copy Markdown
Contributor

I think it would be neater to use contact_links here given that's what they're intended for. For examples, see https://github.com/PyCQA/flake8/issues/new/choose and https://github.com/facebook/react/issues/new/choose

@wookie184
Copy link
Copy Markdown
Contributor

Also, looking at https://github.com/facebook/react/issues/new/choose it seems the option to create a blank issue is pretty hidden away. If we want to add a template for this I think we'd have to add ones for normal usage too.

@shtlrs
Copy link
Copy Markdown
Contributor

shtlrs commented Apr 15, 2023

I think it would be neater to use contact_links here given that's what they're intended for. For examples, see https://github.com/PyCQA/flake8/issues/new/choose and https://github.com/facebook/react/issues/new/choose

Nice ! I didn't know these existed.
In that case, I agree with wookie on the fact that it would look neater if we use contact_links for that.

@wookie184 wookie184 added the s: waiting for author Waiting for author to address a review or respond to a comment label Apr 29, 2023
@wookie184
Copy link
Copy Markdown
Contributor

I'm going to close this as it's been stale for a while and I don't think it's close to merging. Given my second comment:

Also, looking at https://github.com/facebook/react/issues/new/choose it seems the option to create a blank issue is pretty hidden away. If we want to add a template for this I think we'd have to add ones for normal usage too.

I think this would need to go along with #1599 so I'd consider this something that should be solved as part of that issue.

@wookie184 wookie184 closed this Apr 2, 2024
@ChrisLovering ChrisLovering deleted the tag-suggestion-template branch October 31, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: docs Adds or updates documentation p: 2 - normal Normal Priority s: waiting for author Waiting for author to address a review or respond to a comment t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants