Improve test speed with some cached_property decorators#2541
Merged
Conversation
ChrisLovering
approved these changes
Apr 15, 2023
shtlrs
approved these changes
Apr 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are definitely more improvements to be made, and this probably isn't really addressing the root cause, but it is a quick win that should have no effect on behaviour/effectiveness of tests.
Previously on my laptop tests took 50-60 seconds to run, with this change they only take ~20 seconds.
The source of slowdown was discovered using
pytest-profiling.create_autospecis apparently very slow. The changes to therolesonMockGuildhave a smaller improvement but still seem to gain a few seconds.