Don't collect coverage info by default when running tests#2542
Merged
Conversation
ChrisLovering
approved these changes
Apr 16, 2023
shtlrs
approved these changes
Apr 20, 2023
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
We sure like our tests sped up ! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure in 99% of cases when people are running tests they wont be checking coverage, since we don't take coverage too seriously.
Instead of having
poetry run task test-nocovthe option to not collect coverage info, this makes that default and adds apoetry run task test-covoption if coverage info is wanted.For me this doubles the speed of
poetry run task test(from ~20 seconds to ~10 seconds).