Use documented spec extensions in docker compose#2554
Merged
Conversation
The previous method of '<<' no longer works with the latest version of docker compose. This method is what is documented in the [compose spec](https://github.com/compose-spec/compose-spec/blob/master/spec.md#extension)
This is no longer needed as we are not using any 'unsafe' yml on purpose anymore.
ChrisLovering
force-pushed
the
update-docker-compose
branch
from
d465e41 to
1928106
Compare
shtlrs
approved these changes
Apr 22, 2023
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
Tested on:
docker engine 20.10.23
docker compose v2.15.1
wookie184
approved these changes
Apr 22, 2023
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
It seems like there is a version of the previous syntax that works, but this way seems just as good so lgtm. docker/compose#10411 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous method of '<<' no longer works with the latest version of docker compose. This method is what is documented in the compose spec