Skip to content

Message content intent tag#2566

Merged
ChrisLovering merged 17 commits into
python-discord:mainfrom
Canttuchdiz:main
May 5, 2023
Merged

Message content intent tag#2566
ChrisLovering merged 17 commits into
python-discord:mainfrom
Canttuchdiz:main

Conversation

@Canttuchdiz
Copy link
Copy Markdown
Contributor

@Canttuchdiz Canttuchdiz commented Apr 28, 2023

Part of site#695

Includes the tag for the message content intent, describing use case and importance.

Comment thread bot/resources/tags/mcintent.md Outdated
Comment thread bot/resources/tags/mcintent.md Outdated
Comment thread bot/resources/tags/mcintent.md Outdated
Canttuchdiz and others added 2 commits April 27, 2023 21:50
Co-authored-by: Robin <74519799+Robin5605@users.noreply.github.com>
Co-authored-by: Robin <74519799+Robin5605@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@Robin5605 Robin5605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few changes. I think the codeblock example is probably the most important, since it actually shows how users can enable message content intent themselves rather than knowing how it works conceptually

Comment thread bot/resources/tags/mcintent.md Outdated
Comment thread bot/resources/tags/mcintent.md Outdated
Canttuchdiz and others added 2 commits April 27, 2023 22:04
Co-authored-by: Robin <74519799+Robin5605@users.noreply.github.com>
Co-authored-by: Robin <74519799+Robin5605@users.noreply.github.com>
Comment thread bot/resources/tags/mcintent.md Outdated
Co-authored-by: Robin <74519799+Robin5605@users.noreply.github.com>
Comment thread bot/resources/tags/mcintent.md Outdated
Comment thread bot/resources/tags/mcintent.md Outdated
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the file to message-content-intent.md to make it clearer. You can add an alias so the tag can be invoked with the shorter version (see for example https://github.com/python-discord/bot/blob/main/bot/resources/tags/underscore.md)

Comment thread bot/resources/tags/mcintent.md Outdated
@Canttuchdiz Canttuchdiz reopened this Apr 29, 2023
@Xithrius Xithrius added p: 3 - low Low Priority a: tags Related to bot tags t: enhancement Changes or improvements to existing features s: needs review Author is waiting for someone to review and approve labels May 2, 2023
@Xithrius Xithrius requested a review from onerandomusername May 2, 2023 02:32
Comment thread bot/resources/tags/message-content-intent.md Outdated
Comment thread bot/resources/tags/message-content-intent.md Outdated
Copy link
Copy Markdown
Contributor

@Robin5605 Robin5605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

intents.message_content = True # enable message content intents

bot = commands.Bot(command_prefix="!", intents=intents) # actually pass it into the constructor
```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mentioning other relevant tags at the end would be helpful

Suggested change
```
```
For more information on intents, see `/tag intents`. If prefix commands are still not working, see `/tag on-message-event`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of the intents tag, I've just noticed there is a lot of overlap between it and this, maybe we could differentiate the two a bit more?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a good point. I think the beginning is important to have, but maybe removing the part about the privilaged intents, and linking it would be useful. Also, incorporating the fact that you do have to enable it in the discord developer portal at the beginning. Does that sound good?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me. I think the intents tag can also be improved (primarily the length because it is very wordy at the moment) but it would be better addressed in a separate PR.

Co-authored-by: Daniel Gu <daniel.gu25@stu.dulwich.org>
@ChrisLovering ChrisLovering merged commit 1cf9b6c into python-discord:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tags Related to bot tags p: 3 - low Low Priority s: needs review Author is waiting for someone to review and approve t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants