Temporarily remove suport for evaling under 3.10#2618
Merged
Conversation
This is until snekbox supports multi-version natively python-discord/snekbox#158
shtlrs
previously approved these changes
May 30, 2023
3.11 is the default in snekbox:latest now, so no need to have a special container. This also removes all notion of there being diferent containers for different snekbox versions
shtlrs
previously approved these changes
May 30, 2023
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
I can't test this now, but it looks pretty safe to approve the way it is.
shtlrs
approved these changes
May 30, 2023
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
I can't test this now, but it looks pretty safe to approve the way it is.
ChrisLovering
added a commit
to python-discord/site
that referenced
this pull request
May 30, 2023
With python-discord/bot#2618 there will only be 1 snekbox container, that runs the latest verison of snekbox. Supporting multiple versions of snekbox will be covered by python-discord/snekbox#158 where a single instance of snekbox will nativly support multiple Python verisons.
ChrisLovering
added a commit
to python-discord/site
that referenced
this pull request
May 30, 2023
With python-discord/bot#2618 there will only be 1 snekbox container, that runs the latest verison of snekbox. Supporting multiple versions of snekbox will be covered by python-discord/snekbox#158 where a single instance of snekbox will nativly support multiple Python verisons.
ChrisLovering
added a commit
to python-discord/site
that referenced
this pull request
May 30, 2023
With python-discord/bot#2618 there will only be 1 snekbox container, that runs the latest verison of snekbox. Supporting multiple versions of snekbox will be covered by python-discord/snekbox#158 where a single instance of snekbox will nativly support multiple Python verisons.
jchristgit
approved these changes
May 30, 2023
Contributor
jchristgit
left a comment
jchristgit
left a comment
There was a problem hiding this comment.
I can't test this now, but it looks pretty safe to approve the way it is.
python-discord-policy-bot
Bot
dismissed
shtlrs’s stale review
Dismissed because the approval was invalidated by another commit
jchristgit
reviewed
May 30, 2023
Contributor
jchristgit
left a comment
jchristgit
left a comment
There was a problem hiding this comment.
I can't test this now, but it looks pretty safe to approve the way it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is until snekbox supports multi-version natively python-discord/snekbox#158.
This also updates the docker compose environment, so by default just 1 snekbox container is spun up, and updates the list of supported versions to be just 3.11
Closes BOT-3GA Closes #2620