Optimise startup time#2662
Merged
Merged
Conversation
ChrisLovering
requested review from
Den4200,
jb3,
ks129 and
mbaruh
as code owners
BotBase.load_extentions now creates a task by default, so there's no need for us to do this too.
ChrisLovering
force-pushed
the
optimise-startup-time
branch
from
a7beb67 to
cb62526
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 4 cogs that I have modified here were taking ~1 second to load. As only so many tasks can run at once, this slowed down startup time by a decent amount.
I approached this by loading each extension one at a time during startup and picking out the worst offenders.