Make admins confirm edits of other users' reminders#2719
Merged
ChrisLovering merged 12 commits intoAug 26, 2023
Conversation
n0Oo0Oo0b
changed the title
shtlrs
requested changes
Aug 13, 2023
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
Mostly are nitpicks, and this is only a code review, i'll test it later.
shtlrs
requested changes
Aug 14, 2023
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
Works great !
Just a nitpick or two, and a small bug to fix.
n0Oo0Oo0b
commented
Aug 16, 2023
n0Oo0Oo0b
commented
Aug 16, 2023
wookie184
approved these changes
Aug 20, 2023
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
Nice, thanks for working on this.
shtlrs
force-pushed
the
confirm-reminder-edit
branch
from
a8e9c14 to
25ab875
Compare
n0Oo0Oo0b
force-pushed
the
confirm-reminder-edit
branch
from
25ab875 to
ee19428
Compare
Co-authored-by: Amrou Bellalouna <amrbellalouna@gmail.com>
Co-authored-by: Amrou Bellalouna <amrbellalouna@gmail.com>
n0Oo0Oo0b
force-pushed
the
confirm-reminder-edit
branch
from
ee19428 to
2bdd46a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2353
Screenshots:
Confirmation:
When cancelled:
When confirmed: