Bump bot core#2766
Merged
Merged
Conversation
ChrisLovering
commented
Sep 21, 2023
|
|
||
| if "COLOREDLOGS_LOG_FORMAT" not in os.environ: | ||
| coloredlogs.DEFAULT_LOG_FORMAT = format_string | ||
| coloredlogs.DEFAULT_LOG_FORMAT = core_logging.log_format._fmt |
Member
Author
There was a problem hiding this comment.
This is the only thing I'm slightly sad about. Since I didn't surface the logging string used by bot core, this is the only way to get the raw logging string.
I think it's fine, but if anyone feels strongly about it I can update bot core to make this available in a variable.
ChrisLovering
force-pushed
the
bump-bot-core
branch
from
7d54890 to
ca6876b
Compare
ChrisLovering
requested review from
Den4200,
jb3,
ks129 and
mbaruh
as code owners
ChrisLovering
force-pushed
the
bump-bot-core
branch
from
b0c791a to
06bc295
Compare
ChrisLovering
temporarily deployed
to
production
GitHub Actions
Inactive
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps bot core and updates bot to make use of the new logging utils.
The idea with this is to have a consistent place where all bots can pull the logging form at from.