Snekbox: truncate blocked file extensions#2914
Merged
Merged
Conversation
MarkKoz
added
t: bug
MarkKoz
commented
Feb 4, 2024
|
|
||
| return output, paste_link | ||
|
|
||
| async def format_file_text(self, text_files: list[FileAttachment], output: str) -> str: |
Contributor
Author
There was a problem hiding this comment.
This is the same as before. I just refactored it into its own function.
MarkKoz
commented
Feb 4, 2024
| ) | ||
| else: | ||
| blocked_str = self.join_blocked_extensions(blocked_sorted) | ||
| blocked_msg = f"Files with disallowed extensions can't be uploaded: **{blocked_str}**" |
Contributor
Author
There was a problem hiding this comment.
If all extensions are too long then it will just show .... I think this is fine but it's also possible to completely omit : **{blocked_str}** in such case.
shtlrs
approved these changes
Mar 22, 2024
MarkKoz
force-pushed
the
bug/2464/truncate-snekbox-blocked-exts
branch
from
f45ea54 to
37c5e93
Compare
wookie184
requested changes
Mar 25, 2024
Avoid Discord's character limit for messages. Fix #2464
Co-authored-by: wookie184 <wookie1840@gmail.com>
MarkKoz
force-pushed
the
bug/2464/truncate-snekbox-blocked-exts
branch
from
1063442 to
a74dc67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid Discord's character limit for messages.
Fix #2464