Skip to content

Removed rich embed filter as its no longer necessary.#3013

Merged
Xithrius merged 2 commits into
python-discord:mainfrom
Hashed0719:main
Apr 27, 2024
Merged

Removed rich embed filter as its no longer necessary.#3013
Xithrius merged 2 commits into
python-discord:mainfrom
Hashed0719:main

Conversation

@Hashed0719
Copy link
Copy Markdown
Contributor

@Hashed0719 Hashed0719 commented Apr 13, 2024

closes #2977 .

@Hashed0719 Hashed0719 requested a review from mbaruh as a code owner April 13, 2024 04:38
@wookie184 wookie184 added the review: do not merge The PR can be reviewed but cannot be merged now label Apr 14, 2024
wookie184
wookie184 approved these changes Apr 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I'll remove the filter on the server just before merging, once this has another approval from someone.

@wookie184 wookie184 linked an issue Apr 14, 2024 that may be closed by this pull request
Handle an edge case in the rich embed filter. #1938
Closed
@wookie184 wookie184 added the s: needs review Author is waiting for someone to review and approve label Apr 14, 2024
Xithrius
Xithrius approved these changes Apr 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep yep yep

@Xithrius Xithrius enabled auto-merge (squash) April 27, 2024 10:41
@Xithrius Xithrius added a: moderation Related to community moderation functionality: (moderation, defcon, verification) a: filters Related to message filters: (antimalware, antispam, filtering, token_remover) p: 2 - normal Normal Priority t: enhancement Changes or improvements to existing features and removed review: do not merge The PR can be reviewed but cannot be merged now labels Apr 27, 2024
@Xithrius
Copy link
Copy Markdown
Contributor

Xithrius commented Apr 27, 2024

LGTM, thanks.

I'll remove the filter on the server just before merging, once this has another approval from someone.

I have removed the filter.

@Xithrius Xithrius merged commit a47d9ed into python-discord:main Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xithrius Xithrius Xithrius approved these changes

@wookie184 wookie184 wookie184 approved these changes

@mbaruh mbaruh Awaiting requested review from mbaruh mbaruh is a code owner

Assignees

No one assigned

Labels

a: filters Related to message filters: (antimalware, antispam, filtering, token_remover) a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 2 - normal Normal Priority s: needs review Author is waiting for someone to review and approve t: enhancement Changes or improvements to existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove rich_embed filter Handle an edge case in the rich embed filter.

3 participants

@Hashed0719 @Xithrius @wookie184