Skip to content

Copy status_embed workflow from sir-lancebot#3057

Merged
Xithrius merged 1 commit into
mainfrom
improve-status-embed-action
May 19, 2024
Merged

Copy status_embed workflow from sir-lancebot#3057
Xithrius merged 1 commit into
mainfrom
improve-status-embed-action

Conversation

@wookie184
Copy link
Copy Markdown
Contributor

This removes usage of the deprecated ::set-output, and removes a redundant triggering condition
@wookie184 wookie184 requested a review from MarkKoz as a code owner May 19, 2024 22:30
@python-discord-policy-bot python-discord-policy-bot Bot requested a review from a team May 19, 2024 22:30
Comment on lines -72 to -74
actor: ${{ github.actor }}
repository: ${{ github.repository }}
ref: ${{ github.ref }}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the same as the defaults so no need to pass them.

Comment on lines -49 to +36
echo "::set-output name=pr_author_login::$(jq -r '.user.login // empty' pull_request_payload.json)"
echo "::set-output name=pr_number::$(jq -r '.number // empty' pull_request_payload.json)"
echo "::set-output name=pr_title::$(jq -r '.title // empty' pull_request_payload.json)"
echo "::set-output name=pr_source::$(jq -r '.head.label // empty' pull_request_payload.json)"
echo "pr_author_login=$(jq -r '.user.login // empty' pull_request_payload.json)" >> $GITHUB_OUTPUT
echo "pr_number=$(jq -r '.number // empty' pull_request_payload.json)" >> $GITHUB_OUTPUT
echo "pr_title=$(jq -r '.title // empty' pull_request_payload.json)" >> $GITHUB_OUTPUT
echo "pr_source=$(jq -r '.head.label // empty' pull_request_payload.json)" >> $GITHUB_OUTPUT
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@Xithrius Xithrius merged commit 5cad430 into main May 19, 2024
@Xithrius Xithrius deleted the improve-status-embed-action branch May 19, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants