Skip to content

Log and retry OT renaming if Discord returns an error#3145

Merged
jb3 merged 1 commit into
mainfrom
log-failed-OT-name-rename
Aug 14, 2024
Merged

Log and retry OT renaming if Discord returns an error#3145
jb3 merged 1 commit into
mainfrom
log-failed-OT-name-rename

Conversation

@ChrisLovering
Copy link
Copy Markdown
Member

No description provided.

@AaritDutta
Copy link
Copy Markdown

Nice Work!!✨✨

Copy link
Copy Markdown
Contributor

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ChrisLovering! Thank you for the contribution to the bot project!

I have left a review for your work. Overall, I think your code looks good. I have a minor question.

What happens now?

Per our contribution guide, the Python Discord Developer team will review your code and get back to you with comments on what they think about the code. Generally, this will include technical questions, as well as suggestions for improving the readability.

What can you do now?

The best you can do now is wait for further reviews 🙂 Since we are an open source organization and people work on projects in their free time, it might take some time for them to get back to you. Don't fret - they will take a look at it as soon as possible!

Further information

If you feel any part of our process can be improved, we are happy to accept any input from you! Feel free to open an issue in the meta repository with your suggestions. As before, it might take some time for the Python Discord team to get back to you, so don't fret!

Have a great evening!

Comment thread bot/exts/fun/off_topic_names.py
Copy link
Copy Markdown
Contributor

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, the greatest snowball isn't a snowball at all. It's fear.

Comment thread bot/exts/fun/off_topic_names.py
@jb3 jb3 merged commit f1c7b0b into main Aug 14, 2024
@jb3 jb3 deleted the log-failed-OT-name-rename branch August 14, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle Discord's rejection of off-topic channel names due to disallowed words

5 participants