Add tests for bot.converters.

[jchristgit]

I'm going insane. There is a commented out parameter there where pytest fails and I have no idea why. Specifically:

        # ('x' * 128, "Are you insane? That's way too long!"),  # ???ß

Please give that a shot. I have no idea why it's failing, because to the blank eye as well as a Python interpreter (and I directly copied the error string!), the exception raised and the one in the code are the exact same.

[kosayoda]

Looks to be a pytest problem, minimal reproducible example is this:

import pytest


def func():
    raise ValueError("?")


@pytest.mark.parametrize(
    ("expected"), (("?"),)
)
def test_func(expected):
    with pytest.raises(ValueError, match=expected):
        func()

I have no idea what the reason is, but escaping the ? character with a backslash in only the parametrize call works and will pass the test case.

@pytest.mark.parametrize(
    ("expected"), (("\?"),)
)

[avayert]

in the documentation for pytest.raises it says

match –

if specified, a string containing a regular expression, or a regular expression object, that is tested against the string representation of the exception using re.search

passing the result of re.escape as the expected value should work properly

[kosayoda]

Ah, that’s definitely it then, I was dumb.

I checked the source and docs for parametrize instead.

[jchristgit]

Thanks people