Infraction Search Dates#438
Merged
Merged
Conversation
- Changed the date returned on infraction searches to use the `"%c"` strftime format instead of the standard ISO format. Signed-off-by: Daniel Brown <browndj3@gmail.com>
- Changed to use the format `"%Y-%m-%d %H:%M"`, which will turn out looking like `2019-09-18 13:59` Signed-off-by: Daniel Brown <browndj3@gmail.com>
…ttps://github.com/python-discord/bot into hemlock-infraction-date-humanization
jchristgit
reviewed
Sep 18, 2019
- Changed the if statement to use `is None` for code clarity. Signed-off-by: Daniel Brown <browndj3@gmail.com>
MarkKoz
reviewed
Sep 18, 2019
- Corrected an error that would have made the code bug out. Moved a closing parentheses to the correct spot. Signed-off-by: Daniel Brown <browndj3@gmail.com>
MarkKoz
approved these changes
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the rework was launched, the current format for the Created and Expires dates on the infraction search embeds use the standard ISO format, which is a bit of a bear to read.
This PR proposes changing that format to
"%Y-%m-%d %H:%M"which will appear as2019-09-18 13:59