Skip to content

Change log.error to log.exception#443

Merged
MarkKoz merged 5 commits into
python-discord:masterfrom
Akarys42:master
Sep 24, 2019
Merged

Change log.error to log.exception#443
MarkKoz merged 5 commits into
python-discord:masterfrom
Akarys42:master

Conversation

@Akarys42
Copy link
Copy Markdown
Contributor

log.exception(msg) write msg in the log, followed by the full traceback. This PR changes all log.error to log.exception if it's inside a try/except block

This PR closes #382

Copy link
Copy Markdown
Contributor

@GhostofGoes GhostofGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, though that seems like an awful small number of logged exceptions considering the size of the codebase

@Akarys42
Copy link
Copy Markdown
Contributor Author

Almost all log.error are outside of a try/except block, so I can't change them :)

@MarkKoz MarkKoz merged commit 21bb8d7 into python-discord:master Sep 24, 2019
@MarkKoz
Copy link
Copy Markdown
Contributor

MarkKoz commented Sep 24, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log full traceback with log.exception in exception handlers

3 participants