Free Command Fix#455
Merged
Merged
Conversation
- Fixed bug where if two channels had the same last message timestamp the command would error out. Signed-off-by: Daniel Brown <browndj3@gmail.com>
MrHemlock
added
area: cogs
a: frontend
MarkKoz
requested changes
Sep 25, 2019
- Moved the sorted function to its own line and instead passed the generated list for code clarity. Signed-off-by: Daniel Brown <browndj3@gmail.com>
MarkKoz
approved these changes
Sep 25, 2019
SebastiaanZ
reviewed
Sep 25, 2019
- For the sake of code style and consistency, the lambda has been swapped with operator.itemgetter Signed-off-by: Daniel Brown <browndj3@gmail.com>
GhostofGoes
approved these changes
Sep 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #401
Signed-off-by: Daniel Brown browndj3@gmail.com