Skip to content

Allow using double quotes within triple double quotes.#47

Merged
lemonsaurus merged 2 commits intomasterfrom
escape-double-quotes
Apr 12, 2018
Merged

Allow using double quotes within triple double quotes.#47
lemonsaurus merged 2 commits intomasterfrom
escape-double-quotes

Conversation

@jchristgit
Copy link
Copy Markdown
Contributor

1nbze on clickup: "modify the python syntax parser so that it will automatically escape any double quotes within a triple double quote block. currently it is necessary to manually escape these."

When using double quotes within a triple quote block, the Python syntax parser would previously error. This fixes that by escaping any double quotes:

img1
img2

@jchristgit jchristgit requested a review from lemonsaurus April 12, 2018 11:09
Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line
looks fine

@lemonsaurus
Copy link
Copy Markdown
Contributor

Great first PR. Even though it's just one line of code, you've solved the problem, provided a reference for the clickup ticket, and even added screenshots of it in action. I wish all PRs were this good.

@lemonsaurus lemonsaurus merged commit 655aaaa into master Apr 12, 2018
@lemonsaurus lemonsaurus deleted the escape-double-quotes branch April 12, 2018 11:22
Ultros-Bot pushed a commit that referenced this pull request Nov 13, 2018
…'master'

#47: Don't trigger URL filtering on a single message.

See merge request python-discord/projects/bot!85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants