Skip to content

Refactor "Cogs" cog #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jchristgit merged 19 commits into from
Oct 11, 2019
Merged

Refactor "Cogs" cog #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
815f2b7
Rename the "cogs" extension & cog to "extensions"
MarkKoz Oct 2, 2019
4f75160
Add enum for extension actions
MarkKoz Oct 3, 2019
6cdda6a
Simplify extension discovery using pkgutil
MarkKoz Oct 3, 2019
f7109cc
Replace with_role decorator with a cog_check
MarkKoz Oct 3, 2019
19ad439
Add a generic method to manage loading/unloading extensions
MarkKoz Oct 3, 2019
a01a969
Add a custom converter for extensions
MarkKoz Oct 4, 2019
4342f97
Fix the values in the extensions set
MarkKoz Oct 4, 2019
0c0fd62
Use manage method for extensions commands
MarkKoz Oct 4, 2019
c05d0db
Show original exception, if available, when an extension fails to load
MarkKoz Oct 4, 2019
22c9aaa
Fix concatenation of error messages for extension reloads
MarkKoz Oct 4, 2019
37040ba
Support giving multiple extensions to reload
MarkKoz Oct 4, 2019
1fda5f7
Use reload_extension() instead of calling unload and reload
MarkKoz Oct 4, 2019
0f63028
Fix extensions alias
MarkKoz Oct 4, 2019
82fb11c
Invoke the help command when reload is called without args
MarkKoz Oct 4, 2019
cbccb1e
Refactor the extensions list command
MarkKoz Oct 4, 2019
2ece22e
Use quotes instead of back ticks around asterisk in docstrings
MarkKoz Oct 7, 2019
7721635
Support wildcards and multiple extensions for load and unload commands
MarkKoz Oct 7, 2019
da7b23c
Escape asterisks in extensions docstrings
MarkKoz Oct 7, 2019
319cf13
Show help when ext load/unload are invoked without arguments
MarkKoz Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bot/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
bot.load_extension("bot.cogs.antispam")
bot.load_extension("bot.cogs.bot")
bot.load_extension("bot.cogs.clean")
bot.load_extension("bot.cogs.cogs")
bot.load_extension("bot.cogs.extensions")
bot.load_extension("bot.cogs.help")

# Only load this in production
Expand Down
7 changes: 4 additions & 3 deletions bot/cogs/alias.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from discord import Colour, Embed, Member, User
from discord.ext.commands import Bot, Cog, Command, Context, clean_content, command, group

from bot.cogs.extensions import Extension
Comment thread
MarkKoz marked this conversation as resolved.
from bot.cogs.watchchannels.watchchannel import proxy_user
from bot.converters import TagNameConverter
from bot.pagination import LinePaginator
Expand Down Expand Up @@ -84,9 +85,9 @@ async def site_rules_alias(self, ctx: Context) -> None:
await self.invoke(ctx, "site rules")

@command(name="reload", hidden=True)
async def cogs_reload_alias(self, ctx: Context, *, cog_name: str) -> None:
"""Alias for invoking <prefix>cogs reload [cog_name]."""
await self.invoke(ctx, "cogs reload", cog_name)
async def extensions_reload_alias(self, ctx: Context, *extensions: Extension) -> None:
"""Alias for invoking <prefix>extensions reload [extensions...]."""
await self.invoke(ctx, "extensions reload", *extensions)

@command(name="defon", hidden=True)
async def defcon_enable_alias(self, ctx: Context) -> None:
Expand Down
298 changes: 0 additions & 298 deletions bot/cogs/cogs.py
View file
Open in desktop

This file was deleted.

Loading