Prevent too similar off-topic channel names#511
Merged
Conversation
MarkKoz
requested changes
Oct 11, 2019
MarkKoz
approved these changes
Oct 12, 2019
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
Thanks for taking the time to clean up some of the other modules.
jchristgit
approved these changes
Oct 14, 2019
Contributor
|
zoop, conflicts |
MarkKoz
added
a: fun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #465
Currently, there is nothing stopping very similar names being added to the rotation, eg.
kosaandkosaa.To solve this, a check is added that rejects names that have a close match using
difflib.get_close_matcheswith a cutoff of 0.8.A command
!otn forceaddor!otn fawas added to override this check and add the name to the rotation anyway.