Move the security cog tests to unittest.#525
Merged
Merged
Conversation
jchristgit
added
a: backend
MarkKoz
approved these changes
Oct 12, 2019
SebastiaanZ
reviewed
Oct 13, 2019
Comment on lines
+15
to
+18
| self.bot = MagicMock() | ||
| self.cog = security.Security(self.bot) | ||
| self.ctx = MagicMock() | ||
| self.ctx.author = MagicMock() |
Contributor
There was a problem hiding this comment.
There are some mock helpers set-up for Bot and Context in tests.helpers that follow the specifications of the objects they're mocking (using the spec parameter of Mock/MagicMock) and have some commonly used attributes already set up (like the author attribute for the Context mock with a Member mock that follows the discord.Member spec and send for the Context mock with an AsyncMock).
jchristgit
commented
Oct 13, 2019
Contributor
Author
jchristgit
left a comment
jchristgit
left a comment
There was a problem hiding this comment.
hello no i just wanted to reply to the comment not start a review tyvm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.