Skip to content

Reduce !free output#527

Merged
MarkKoz merged 5 commits into
python-discord:masterfrom
kraktus:compact_free
Oct 25, 2019
Merged

Reduce !free output#527
MarkKoz merged 5 commits into
python-discord:masterfrom
kraktus:compact_free

Conversation

@kraktus
Copy link
Copy Markdown
Contributor

@kraktus kraktus commented Oct 12, 2019

Closes #274
current output:

What was proposed in the issue:

My proposal:
Screen Shot 2019-10-12 at 22 31 08

I left the list to make clearer the fact that the output is ordered and stressed the timer.

Comment thread bot/cogs/free.py
Comment thread bot/cogs/free.py Outdated
Copy link
Copy Markdown
Contributor

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason your picture looks worse than the original proposal. I am pretty sure it's just a difference in fonts. Yours has a lot less space between lines which worsens legibility to the point of me almost not wanting it to be formatted it that way.

@MarkKoz MarkKoz added a: frontend Related to output and formatting type: enhancement labels Oct 14, 2019
@kraktus
Copy link
Copy Markdown
Contributor Author

kraktus commented Oct 15, 2019

Screen Shot 2019-10-15 at 18 42 27

This is a closer screenshot. We can see that the channels's mention are not aligned, but I don't understand why, according to the code it should be the case.

@scragly
Copy link
Copy Markdown
Contributor

scragly commented Oct 21, 2019

I'm not a fan of the numbering, as it's not really useful (it has the times already present) and only serves to prevent alignment of the mentions, making it slightly uglier.

I think the footer should also still be an actual footer to keep it separated from the main output and to keep the text size slightly smaller.

@lemonsaurus
Copy link
Copy Markdown
Contributor

I agree with Scragly. I don't think your proposal is an improvement on the proposal in the original issue, so I'd like to see it changed to what the original proposal was. No numbers, text in footer.

@kraktus
Copy link
Copy Markdown
Contributor Author

kraktus commented Oct 21, 2019

Screen Shot 2019-10-21 at 14 39 16

Comment thread bot/cogs/free.py Outdated
Copy link
Copy Markdown
Contributor

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change (which others may disagree with). Everything else is in order.

Comment thread bot/cogs/free.py Outdated
@sco1 sco1 requested a review from MarkKoz October 25, 2019 13:23
@MarkKoz MarkKoz merged commit dd3b2de into python-discord:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: frontend Related to output and formatting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restricting/redirecting output of commands to bot-commands for regular users

6 participants