Change on_message_edit - only show differences, highlighted in blue with hyperlink#646
Merged
Conversation
- Merged `before_response` and `after_response`. - Only show the differences between `before.clean_content` and `after.clean_content` - Included a `jump to message` link.
ikuyarihS
added
area: cogs
a: moderation
... I think?
- A simple `http://.z` will show properly for PC client, but for android it completely broke -> changed to `http://o.hi` - minimum link to make discord think it's a link.
MarkKoz
requested changes
Nov 5, 2019
Following Mark's reviews:
- The single `if` inside the `else` can be merged with its `else` - this will reduce the level of complexity and indentation.
- Changed from style
```py
new = ('hello'
'world')
```
to
```py
new = (
'hello'
'world'
)
```
to be more consistent with the rest of the code
Contributor
|
This doesn't work quite well in this case:
Is this some obvious bug somewhere or just an inaccuracy we have to live with using difflib (in that case, would another library/approach be more accurate)? |
Contributor
Author
|
It's more of a logic bug, since I'm using |
…trol over each word.
MarkKoz
approved these changes
Nov 13, 2019
scragly
suggested changes
Nov 15, 2019
…t_before` and `content_after`
Contributor
|
I love this idea, very creative. |
lemonsaurus
reviewed
Nov 30, 2019
scragly
approved these changes
Nov 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #632
Example:
Before edit:
There's clearly an easier way to handle this particular data by not using a relational db, but with how much of it does work with one, I'm having trouble judging if that solution is fine, or needs other handling.After edit:
There's clearly an easier way to handle this data by not using a relational db, but with how much of it does work extremely well with one, I'm having trouble judging if that solution is acceptable, or needs other handling.Embed will then show this:
