Refactor information.py with lots of changes that makes the overall code cleaner and faster#741

Merged

sco1 merged 16 commits into

python-discord:masterfrom

Denayder:information-refactor

Feb 23, 2020

Commits on Feb 6, 2020

No longer check if every role is @everyone; just skip the first element in the list
Deniz
committed
Roles cannot return None because everyone has the Developer role by default, and non-verified users cannot use this command.
Deniz
committed
Remove some a lot of unneccesary newlines that arguably make it harder to read
Deniz
committed
Refactor how channels and statuses are counted; using Counter() - way cleaner.
Deniz
committed
Update tests to reflect status changes
Deniz
committed
Instead of sending a message everytime a role can't be converted, append it to a list, and then send them it at once (less spammy)
Deniz
committed
Fix up imports a bit; there's no need to import all of discord and typing for just 1 or 2 uses (e.g. Union, and Message).
Deniz
committed
Change if statement to elif; if the first if statement returns true, the second cannot be true making it unneccesary to check
Deniz
committed
Fix some of the testing for information.py; I think this should be it. (hopefully).
Deniz
committed

Commits on Feb 8, 2020

Use the enum itself instead of its string value
Deniz
committed

Commits on Feb 12, 2020

Use collections.Counter properly. Use the ChannelType enum instead of the __class__ attribute, and re-add the None check for !user roles.
Deniz
committed

Commits on Feb 13, 2020

Commits on Feb 21, 2020

Commits on Feb 23, 2020

Merge branch 'master' into information-refactor
sco1
authored